Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review and Feedback #18

Open
electricblues opened this issue Jan 23, 2024 · 1 comment
Open

Code Review and Feedback #18

electricblues opened this issue Jan 23, 2024 · 1 comment

Comments

@electricblues
Copy link

Overall, I think the website is quite complex - it provides a good user experience and has a lot of fun, interactive elements.
Keep up the good work!

Positive Feedback:

HTML

  • Your HTML is wonderfully organized! The clear sections make it a breeze to navigate and understand.
  • Love how you've used semantic elements like <header>, <main>, <footer>, <section>, and <nav>. It really boosts readability and SEO - nice job!
  • The way you've linked stylesheets and icons in the <head> is super tidy. It keeps everything well-organized.

CSS

  • Defining variables in :root for colors and fonts is a great touch for maintaining consistency. Keep it up!
  • Your media queries show you've got a solid grasp on responsive design. This ensures your site looks great on all devices.
  • Your CSS structure is so clean and well-segmented. It makes understanding different components easy for the reader.

JavaScript

  • The names you've chosen for your functions are spot-on and make it easy to understand their purpose.
  • Your comments do a fantastic job explaining what each function is for. This really helps in understanding your code logic.
  • Importing isElementValid from a utility file is a great move for code reusability.

Areas for Improvement:

HTML

  • Adding a few more comments to the larger sections, like forms or navigation menus, could make maintenance and understanding even easier.
  • If there's any inline CSS, consider moving it to your external stylesheet. It helps keep everything more manageable.

CSS

  • Watch out for those overly specific selectors. Simplifying them a bit can make maintaining your stylesheet easier.
  • A few additional comments could be really helpful, especially in breaking down larger sections for easier readability.
  • Try to keep the use of !important to a minimum. It can create some tricky conflicts down the road.

JavaScript

  • If you find yourself using elements like navSpinner in several places, how about querying them just once? It could save you some time and keep your code cleaner.
  • That ERROR_MSG constant is handy – make sure you're using it consistently across your code for better clarity.
@blackNoir2
Copy link
Collaborator

blackNoir2 commented Jan 23, 2024 •
edited
Loading

Thank you for your detailed feedback! It effectively captures both the positives and areas for improvement and is aesthetically arranged on the page. I appreciate your insights. We also implement the things you stated.

Your point about querying something only once, and using it over and over again is indeed valid. However, regarding the navSpinner you mentioned, the result is queried only once, stored in the navSpinner variable, and efficiently utilized within the confines of the handleNavspinner function. This variable is not queried again and remains exclusive to its designated function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@electricblues @blackNoir2