Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simon's Code Review #46

Open
simonryrie opened this issue Jul 26, 2023 · 0 comments
Open

Simon's Code Review #46

simonryrie opened this issue Jul 26, 2023 · 0 comments
Assignees
@hanleymark

Comments

@simonryrie
Copy link

  • Location API with autocomplete is really cool! UI looks great, especially on mobile.

  • I like your tests for the carousel and google maps!

  • Listings view is a bit confusing on desktop - I didn’t work out the map was relating to the individual property initially. Perhaps map could be smaller to make it more clearly linked?

  • Price icon is a bit confusing

  • Can see login is still WIP - only feedback would be that I don’t expect to be able to sign up while logged in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanleymark hanleymark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hanleymark @FomasTreeman @cameochoquer @simonryrie @camelPhonso