Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOW 🤩 #46

Open
hannahgooding opened this issue Apr 24, 2020 · 2 comments
Open

WOW 🤩 #46

hannahgooding opened this issue Apr 24, 2020 · 2 comments

Comments

@hannahgooding
Copy link

Awesome that you used you're own API and really cool app idea and implementation. Interesting that you've chosen to combine the backend and frontend into one application, rather than sending requests to an external API, we would be curious to know the reason behind this.

Great job with validation and nice interface, so much done in so little time, wow! Code snippets look beautiful, cool library for syntax highlighting.

@VatsKan
Copy link

VatsKan commented Apr 24, 2020

nice file structure, easy to navigate code also

@Roger-Heathcote
Copy link
Contributor

@hannahgooding We bundled it all as one for two reasons. Firstly we figured we might have to make some changes to the API code (and we did) so it would be easier to have a single codebase rather than two. Secondly we didn't feel like risking CORS problems as we hadn't designed our API with that inmind last week. Serving everything from the same origin mitigates that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants