Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorisation #59

Open
jackherizsmith opened this issue May 29, 2020 · 1 comment
Open

Authorisation #59

jackherizsmith opened this issue May 29, 2020 · 1 comment
Labels
code review complement question Further information is requested

Comments

@jackherizsmith
Copy link

Was surprised to find authorisation inside the one express route that needs it - nice. This might need to be abstracted back to middleware in the case of future authorised-only routes (e.g. user settings?)
@jackherizsmith jackherizsmith added question Further information is requested code review complement labels May 29, 2020
@akomiqaia
Copy link
Collaborator

You are absolutely right and we intend to when we have reached a stage where users can edit their setting 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code review complement question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akomiqaia @jackherizsmith