Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complements #59

Open
jackbridger opened this issue Dec 19, 2019 · 0 comments
Open

Complements #59

jackbridger opened this issue Dec 19, 2019 · 0 comments

Comments

@jackbridger
Copy link

jackbridger commented Dec 19, 2019

+++ SIIIIIIIIIICK ANIMATIONS
+++SUCH A COOL IDEA. It made me really happy when the page loaded. FAC needs this.
+++ Looks fantastic. So bold with the background. Nice font choices. Seasonal footer 🥇
+++ You deployed it!!!!
+++ go fac yourself
+++ It's responsive
+++ Strong team letters
+++ CSS Vars mm mm mmmm. Generally awesome CSS 👏
+++ Creative use of an external link as part of site (the proj gallery)
+++ I'm afraid to test your delete function - I think that's a positive!
+++ You took the action points really seriously - love this approach
+++ 93 Accessibility & 91 SEO. Gonna clean up on Bing/Google.
+++ You used const a lot 👍 amazing
+++ LOads of tests!!
+++ You used the $s to protect against SQL injections :)

Love this line

const [username, password] = params.auth.split(":");

+++ Some great commit messages, for example

  • Reda: add css variables for colours, spacing, add reenie-beanie font, add background image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant