Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification Needed: Minimum Node.js Version for CI GitHub Action #229

Open
carpasse opened this issue Apr 17, 2024 · 4 comments
Open

Clarification Needed: Minimum Node.js Version for CI GitHub Action #229

carpasse opened this issue Apr 17, 2024 · 4 comments

Comments

@carpasse
Copy link

Main Issue
We need to clarify the minimum version of Node.js that our repositories' Continuous Integration (CI) GitHub Actions are expected to run on.

Context
While working on the initiative to add scorecards to Express.js organizations' repositories, we've been addressing any failing Continuous Integration (CI) GitHub Actions. However, we've encountered inconsistencies regarding the minimum version of Node.js required to run the CI tests.

For example:

  • mime-db sets Node.js 0.6 as its minimum version.
  • express sets Node.js 0.10 as its minimum version.
  • final handler sets Node.js 0.8 as its minimum version.

We need to standardize the minimum Node.js version across all repositories to ensure consistency and compatibility.

Proposal
I propose opening this issue to discuss and decide on a unified minimum version of Node.js for all repositories' CI GitHub Actions within the Express.js organizations.

@wesleytodd
Copy link
Member

All of those need to remain as is until we start updating them for major bumps. When we go to v5 for express most of those will likely land a few breaking changes as well as drop many node versions in the test matrix.

@sheplu can you link to the current discsussion for the LTS strategy doc pr? I am not sure if it has moved from this one to the admin repo yet.

@carpasse
Copy link
Author

@wesleytodd some repositories are still using travis Is it ok to migrate them to github actions respecting the specified Node.js versions?

@UlisesGascon
Copy link
Member

All of those need to remain as is until we start updating them for major bumps. When we go to v5 for express most of those will likely land a few breaking changes as well as drop many node versions in the test matrix.

I think that for the minimum version, there's a different history, and we can establish a general rule before v5 is released, as it is an independent event.

  • As a general rule, any dependency or sub-dependency of Express v4 should at least support Node 0.10, as it is the minimum supported version for Express@4 today.
  • Any other project in the organization (including Express dependencies and sub-dependencies) that supports lower versions than 0.10 currently in their CI pipelines can serve as a reminder, just in case other projects or users depend on it. So in this context final handler supports [email protected] and mime-db supports Node@06
  • Once Express@5 is released, the minimum Node.js version will obviously change for the next major version of those libraries that the project depends on.

Side note: Dropping support for any specific Node.js version is considered a major semver change, while extending support to new ones is a minor semver change (AFAIK).

some repositories are still using travis Is it ok to migrate them to github actions respecting the specified Node.js versions?

Migrating to GitHub Actions is the way.

@wesleytodd
Copy link
Member

wesleytodd commented Apr 18, 2024

I think that for the minimum version, there's a different history, and we can establish a general rule before v5 is released

I agree we can set a rule, and as long as we keep to your point made in the "side note" (many of those packages are used outside of express and we cannot just change the supported node versions without a major bump) then I am good.

Is it ok to migrate them to github actions respecting the specified Node.js versions?
Migrating to GitHub Actions is the way.

Yep absolutely!!!

EDIT: I realize my original wording may have been confusing. I meant "they need to keep those node versions" not that we shouldn't improve them in general (like moving to actions for example). Sorry for the confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants