-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification Needed: Minimum Node.js Version for CI GitHub Action #229
Comments
All of those need to remain as is until we start updating them for major bumps. When we go to v5 for @sheplu can you link to the current discsussion for the LTS strategy doc pr? I am not sure if it has moved from this one to the admin repo yet. |
@wesleytodd some repositories are still using travis Is it ok to migrate them to github actions respecting the specified Node.js versions? |
I think that for the minimum version, there's a different history, and we can establish a general rule before v5 is released, as it is an independent event.
Side note: Dropping support for any specific Node.js version is considered a major semver change, while extending support to new ones is a minor semver change (AFAIK).
Migrating to GitHub Actions is the way. |
I agree we can set a rule, and as long as we keep to your point made in the "side note" (many of those packages are used outside of express and we cannot just change the supported node versions without a major bump) then I am good.
Yep absolutely!!! EDIT: I realize my original wording may have been confusing. I meant "they need to keep those node versions" not that we shouldn't improve them in general (like moving to actions for example). Sorry for the confusion! |
Main Issue
We need to clarify the minimum version of Node.js that our repositories' Continuous Integration (CI) GitHub Actions are expected to run on.
Context
While working on the initiative to add scorecards to Express.js organizations' repositories, we've been addressing any failing Continuous Integration (CI) GitHub Actions. However, we've encountered inconsistencies regarding the minimum version of Node.js required to run the CI tests.
For example:
We need to standardize the minimum Node.js version across all repositories to ensure consistency and compatibility.
Proposal
I propose opening this issue to discuss and decide on a unified minimum version of Node.js for all repositories' CI GitHub Actions within the Express.js organizations.
The text was updated successfully, but these errors were encountered: