simplify per CR feedback

Author: humbletim

examples/realitytabs.html

@@ -592,11 +592,11 @@
     }
   }
 
-  const _drawOk = (src) => {
-    console.log('reality tab load ok: ' + src);
+  const _drawOk = () => {
+    console.log('reality tab load ok: ' + u);
   };
-  const _drawFail = (src) => {
-    console.log('reality tab load error: ' + src);
+  const _drawFail = () => {
+    console.log('reality tab load error: ' + u);
   };
 
   const iframe = document.createElement('iframe');
@@ -617,11 +617,11 @@
       }
     })();
     if (contentDocument) {
-      _drawOk(iframe.src);
+      _drawOk();
 
       // scene.background = null;
     } else {
-      _drawFail(iframe.src || u);
+      _drawFail();
 
       _closeTab(tab);
 

src/DOM.js

@@ -309,7 +309,7 @@ Node.DOCUMENT_TYPE_NODE = 10;
 Node.DOCUMENT_FRAGMENT_NODE = 11;
 module.exports.Node = Node;
 
-const _setAttributeRaw = (el, prop, value, notify = true) => {
+const _setAttributeRaw = (el, prop, value) => {
   if (prop === 'length') {
     el.attrs.length = value;
   } else {
@@ -320,11 +320,11 @@ const _setAttributeRaw = (el, prop, value, notify = true) => {
         value,
       };
       el.attrs.push(attr);
-      notify && el._emit('attribute', prop, value, null);
+      el._emit('attribute', prop, value, null);
     } else {
       const oldValue = attr.value;
       attr.value = value;
-      notify && el._emit('attribute', prop, value, oldValue);
+      el._emit('attribute', prop, value, oldValue);
     }
   }
 };
@@ -2200,8 +2200,6 @@ class HTMLIFrameElement extends HTMLSrcableElement {
                 const options = parentWindow[symbols.optionsSymbol];
 
                 url = _normalizeUrl(res.url, options.baseUrl);
-                // passively update .src with the final url (which can differ in case of redirects)
-                _setAttributeRaw(this, 'src', url, false);
                 const parent = {};
                 const top = parentWindow === parentWindow.top ? parent : {};
                 this.contentWindow = _makeWindow({