Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Fix Label Tag Size in Kanban Board #3567

Merged
merged 1 commit into from
Feb 2, 2025
Merged

[Improvement]: Fix Label Tag Size in Kanban Board #3567

merged 1 commit into from
Feb 2, 2025

Conversation

sv7000
Copy link
Contributor

@sv7000 sv7000 commented Feb 1, 2025 •
edited
Loading

closes #3566

Description

The Label Tag Button on the Kanban Board page has been corrected, and its size is now consistent with the other tags in the "Create New Task" popup.

Steps to Reproduce:

  1. Navigate to the Dashboard.
  2. Click on the Kanban page.
  3. Pick any card and click on "Create New Task."
  4. Type anything in the search box, and the tags will appear.

Expected Behavior:

  • The Label Tag size should be the same as other tags present.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous Screenshots

Screenshot 2025-01-31 at 11 41 48 PM

Current Screenshots

Screenshot 2025-01-31 at 11 44 20 PM

Summary by CodeRabbit

  • Style
    • Updated the height of task labels in the Kanban view to improve visual presentation.

@sv7000 sv7000 self-assigned this Feb 1, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 1, 2025 •
edited
Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/lib/features/task/task-input-kanban.tsx

Oops! Something went wrong! :(

ESLint: 8.46.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request introduces a minor visual modification to the TaskLabels component within the TaskCard function. Specifically, the height of the component is changed from h-7 to h-11, which will alter the visual presentation of the task creation form's layout. This change appears to be a subtle UI adjustment that impacts the component's vertical spacing.

Changes

File Change Summary
apps/web/lib/features/task/task-input-kanban.tsx Modified TaskLabels component height from h-7 to h-11

Suggested labels

UI/UX, Bug fix, Ever Teams

Suggested reviewers

  • evereq
  • Cedric921

Poem

🐰 A rabbit's tale of pixels tall,
Where labels stretch and heights enthrall,
From seven to eleven, a height so neat,
Our UI dance is now complete!
Hop, hop, hurray for design's delight! 🎨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5650129 and 9290ee8.

📒 Files selected for processing (1)
  • apps/web/lib/features/task/task-input-kanban.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/web/lib/features/task/task-input-kanban.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: deploy

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@evereq evereq merged commit c261280 into develop Feb 2, 2025
13 checks passed
@evereq evereq deleted the Fix/Label-tag-button branch February 2, 2025 06:35
@coderabbitai coderabbitai bot mentioned this pull request Feb 4, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Innocent-Akim Innocent-Akim Innocent-Akim approved these changes

@evereq evereq Awaiting requested review from evereq

Assignees

@sv7000 sv7000

Labels
Ever Teams UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Label Tag Button Size is Incorrect
3 participants
@sv7000 @Innocent-Akim @evereq