Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-sql-server-batch: new batch connector in line with the others #2461

Closed
willdonnelly opened this issue Feb 27, 2025 · 0 comments · Fixed by #2503
Closed

source-sql-server-batch: new batch connector in line with the others #2461

willdonnelly opened this issue Feb 27, 2025 · 0 comments · Fixed by #2503
Assignees
Labels
change:planned This is a planned change

Comments

@willdonnelly
Copy link
Member

willdonnelly commented Feb 27, 2025

Exactly what it says on the tin. This should probably be a copy-paste of source-postgres-batch with the XMIN logic stripped out, and appropriate tweaks to the connection setup and discovery logic to make everything work nicely. Slap a bunch of datatype and various edge case tests on it and we're done!

One thing we might want to consider: SQL Server has no direct equivalent to the PostgreSQL xmin or Oracle ORA_ROWSCN system columns, but it does have a column type ROWVERSION which does something very similar when it's present as a column on a particular table (you just have to have added it yourself, it's not there by default). We should consider whether it's worth the effort of detecting when a source table has a column of that type and using it as the cursor automatically, versus just defaulting to full-refresh behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:planned This is a planned change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant