Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-stripe-native: some streams' incremental replications aren't happening #1965

Open
Alex-Bair opened this issue Sep 19, 2024 · 0 comments
Assignees

Comments

@Alex-Bair
Copy link
Contributor

Summary

Some streams for source-stripe-native are not replicating incrementally despite data being created/updated in Stripe. For example:

  • ApplicationFees: The incorrect event type is being checked. The connector is checking for application_fee.refunded events when it should be checking for both application_fee.created and application_fee.updated events.
  • Refunds: No refund events are generated by Stripe. Despite the Stripe API documentation listing refund.created and refund.updated events, these events are not present on the /events endpoint when a refund is created/updated.

Other streams may have these issues too, but they haven't popped up yet or are only checking for a subset of the appropriate events (i.e. only checking for .updated and not .created). It wouldn't be a bad idea to audit all events we're checking & confirm they are actually being created in Stripe. We should also make sure we're checking for all appropriate events for each stream.

A possible solution includes the following:

  • Checking for different event types between parent streams vs. child streams. Right now, they always check the same event type.
  • Checking for multiple event types using an array of types as query params (specified like types[0], types[1], etc.) instead of checking for only a single type with the type param.
  • Switching any streams that don't actually have create/update events over to the existing "no event" resource type.
@Alex-Bair Alex-Bair self-assigned this Sep 19, 2024
@Alex-Bair Alex-Bair changed the title source-stripe-native: some streams' incremental replication isn't happening source-stripe-native: some streams' incremental replications aren't happening Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant