Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-stripe-native: Only discover available bindings #1946

Closed
Alex-Bair opened this issue Sep 16, 2024 · 0 comments · Fixed by #1960
Closed

source-stripe-native: Only discover available bindings #1946

Alex-Bair opened this issue Sep 16, 2024 · 0 comments · Fixed by #1960
Assignees
@Alex-Bair

Comments

@Alex-Bair
Copy link
Contributor

Alex-Bair commented Sep 16, 2024 •
edited
Loading

Summary

Stripe users can provide restricted API keys, which limits which Stripe resources the connector can access. If a connector tries to requests a resource it don't have permission to access, the connector crashes.

To avoid these crashes, the connector should only discover bindings that it has permission to access.

Note: This is the same issue as #1782 but the desired solution is different.

Status

17SEP - Fix is progressing well and mostly coded up. I have a few additional tests I want to run to ensure I won't unexpectedly break any streams, but I should have a PR up in the next day or so.
@Alex-Bair Alex-Bair self-assigned this Sep 16, 2024
@Alex-Bair Alex-Bair linked a pull request Sep 17, 2024 that will close this issue
source-stripe-native: only discover accessible streams #1960
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex-Bair Alex-Bair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

source-stripe-native: only discover accessible streams estuary/connectors
1 participant
@Alex-Bair