Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202408 comments lp 128 #417

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from
Open

Conversation

anthonylindsay
Copy link
Collaborator

Enables comments for news articles
adds like-dislike module for news articles
sets permissions for auth users to comment and editors to administer them

https://eccservicetransformation.atlassian.net/browse/LP-128

@Polynya
Copy link
Collaborator

Polynya commented Sep 2, 2024

/start

@Polynya
Copy link
Collaborator

Polynya commented Sep 2, 2024

/start

Copy link

github-actions bot commented Sep 2, 2024

Starting Review App.

@Polynya
Copy link
Collaborator

Polynya commented Sep 2, 2024

/start

Copy link

github-actions bot commented Sep 2, 2024

Starting Review App.

Copy link

github-actions bot commented Sep 2, 2024

@Polynya
Copy link
Collaborator

Polynya commented Oct 17, 2024

/rebuild

Copy link

Rebuilding the Review App (without resetting the database)

Copy link

@anthonylindsay
Copy link
Collaborator Author

/rebuild

Copy link

Rebuilding the Review App (without resetting the database)

Copy link

@anthonylindsay
Copy link
Collaborator Author

/rebuild

Copy link

Rebuilding the Review App (without resetting the database)

Copy link

@anthonylindsay
Copy link
Collaborator Author

@Polynya thanks for those changes Adrian

@Polynya
Copy link
Collaborator

Polynya commented Oct 17, 2024

/rebuild

Copy link

Rebuilding the Review App (without resetting the database)

@Polynya
Copy link
Collaborator

Polynya commented Oct 17, 2024

No problem. As well as ecc_comments, I think Codesniffer was updated and started reporting new types of errors in other places.

Copy link

@Polynya
Copy link
Collaborator

Polynya commented Oct 17, 2024

These are useful commands to run before trying to run a Review App:

  • composer phpcs - run CodeSniffer
  • composer phpcbf - fix some CodeSniffer issues
  • composer tests-required - run CodeSniffer and check for security updates - this is run in the pipeline

@Polynya
Copy link
Collaborator

Polynya commented Oct 29, 2024

/rebuild

Copy link

Rebuilding the Review App (without resetting the database)

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants