Add support for font glyphsets to fix non-Unicode character rendering #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Add glyphsets in substitutions and use that for all fonts
Add font glyphsets to different s3 models also
HLandstrom
added a commit
to HLandstrom/wake-word-voice-assistants
that referenced
this pull request
Dec 11, 2024
|
Added the changes in this PR into my config and it works as it should. |
clydebarrow
approved these changes
Jan 11, 2025
HLandstrom
added a commit
to HLandstrom/wake-word-voice-assistants
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue discussed in issue #36, where accentuated letters and other non-ASCII characters are not displayed correctly on the ESP32-S3-Box-3. Following changes in PR #34, these characters now render as black rectangles.
The implementation adds support for defining glyphsets in the font configuration, allowing users to specify required character sets explicitly. This resolves rendering issues for extended Latin and other Unicode characters when using Google Fonts.