Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ready to merge" bugs #22

Open
not-an-aardvark opened this issue Oct 17, 2017 · 2 comments
Open

"Ready to merge" bugs #22

not-an-aardvark opened this issue Oct 17, 2017 · 2 comments
Labels

Comments

@not-an-aardvark
Copy link
Member

not-an-aardvark commented Oct 17, 2017

I think the "ready to merge" plugin has a few issues:

  • It gets triggered by a single status check changing on a PR, even if there are multiple status checks. So if a status check fails, and then a different status check passes, it will add the label.
  • It will respond to any approval review, even a review that isn't from a team member
  • Also, the three concerns from Plugin status and discussion #3 (comment)
@gyandeeps
Copy link
Member

This plugin is already disabled.

@not-an-aardvark
Copy link
Member Author

Fair enough -- I'm just bringing these up in case we decide to enable it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants