Run type tests against different versions of ESLint and TS during CI

Author: aryaemami59

Diff for: .github/workflows/ci.yml

@@ -43,8 +43,7 @@ jobs:
         run: npm run lint
 
   test:
-    name:
-      🧪 Test (Node@${{ matrix.node }} - ESLint@${{ matrix.eslint }} - ${{
+    name: 🧪 Test (Node@${{ matrix.node }} - ESLint@${{ matrix.eslint }} - ${{
       matrix.os }})
     strategy:
       fail-fast: false
@@ -118,12 +117,54 @@ jobs:
       - name: ▶️ Run test:types script
         run: npm run test:types
 
+  type-tests:
+    name: 🧪 Type tests with ESLint ${{ matrix.eslint }} and TypeScript ${{ matrix.ts }}
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+
+      matrix:
+        eslint: [8, 9]
+        ts: ["5.0", "5.1", "5.2", "5.3", "5.4", "5.5", "5.6"]
+
+    steps:
+      - name: ⬇️ Checkout repo
+        uses: actions/checkout@v4
+
+      - name: ⎔ Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 18
+
+      - name: 📥 Install dependencies
+        run: npm install
+
+      - name: Pack the package
+        id: pack
+        run: npm install "$(npm pack | tail -n1)"
+
+      - name: 📥 Uninstall @types/eslint
+        if: matrix.eslint != 8
+        run: npm uninstall @types/eslint
+
+      - name: 📥 Install ESLint version ${{ matrix.eslint }}
+        run: npm install --save-dev eslint@${{ matrix.eslint }}
+
+      - name: 📥 Install TypeScript version ${{ matrix.ts }}
+        run: npm install --save-dev typescript@${{ matrix.ts }} -f
+
+      - name: ▶️ Run test:types script
+        run: npm run test:types
+
+      - name: 📝 List version of ESLint
+        run: npm why eslint @types/eslint
+
   release:
     name: 🚀 Release
-    needs: [ lint, test ]
+    needs: [lint, test]
     runs-on: ubuntu-latest
-    if:
-      github.repository == 'eslint-community/eslint-plugin-eslint-comments' &&
+    if: github.repository == 'eslint-community/eslint-plugin-eslint-comments' &&
       contains('refs/heads/main,refs/heads/next,refs/heads/beta,refs/heads/alpha',
       github.ref) && github.event_name == 'push'
     steps:

Diff for: package.json

@@ -49,7 +49,7 @@
     "cross-spawn": "^7.0.3",
     "esbuild": "^0.19.3",
     "eslint": "^8.46.0",
-    "expect-type": "^1.1.0",
+    "expect-type": "^1.2.0",
     "fs-extra": "^10.1.0",
     "mocha": "^10.4.0",
     "monaco-editor": "^0.47.0",

Diff for: tests/types/configs.test-d.cts

@@ -7,12 +7,12 @@ import expectTypeOf = expectTypeModule.expectTypeOf
 
 expectTypeOf(configs)
   .toHaveProperty("recommended")
-  .toMatchTypeOf<Linter.FlatConfig>()
+  .toExtend<Linter.FlatConfig>()
 
-expectTypeOf([configs.recommended]).toMatchTypeOf<Linter.FlatConfig[]>()
+expectTypeOf([configs.recommended]).toExtend<Linter.FlatConfig[]>()
 
-expectTypeOf(configs.recommended).toMatchTypeOf<Linter.FlatConfig>()
+expectTypeOf(configs.recommended).toExtend<Linter.FlatConfig>()
 
 expectTypeOf(configs)
   .toHaveProperty("recommended")
-  .toMatchTypeOf<Linter.FlatConfig>()
+  .toExtend<Linter.FlatConfig>()

Diff for: tests/types/configs.test-d.mts

@@ -4,12 +4,12 @@ import { expectTypeOf } from "expect-type"
 
 expectTypeOf(configs)
   .toHaveProperty("recommended")
-  .toMatchTypeOf<Linter.FlatConfig>()
+  .toExtend<Linter.FlatConfig>()
 
-expectTypeOf([configs.recommended]).toMatchTypeOf<Linter.FlatConfig[]>()
+expectTypeOf([configs.recommended]).toExtend<Linter.FlatConfig[]>()
 
-expectTypeOf(configs.recommended).toMatchTypeOf<Linter.FlatConfig>()
+expectTypeOf(configs.recommended).toExtend<Linter.FlatConfig>()
 
 expectTypeOf(configs)
   .toHaveProperty("recommended")
-  .toMatchTypeOf<Linter.FlatConfig>()
+  .toExtend<Linter.FlatConfig>()

Diff for: types/index.d.ts

@@ -1,6 +1,6 @@
 import type { ESLint, Linter } from "eslint"
 
-export declare const configs: { recommended: Linter.FlatConfig }
+export declare const configs: { recommended: Linter.LegacyConfig }
 
 export declare const rules: NonNullable<ESLint.Plugin["rules"]>