Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notification on job finished #629

Open
erwindon opened this issue Sep 7, 2024 · 0 comments
Open

add notification on job finished #629

erwindon opened this issue Sep 7, 2024 · 0 comments
Assignees

Comments

@erwindon
Copy link
Owner

erwindon commented Sep 7, 2024

Is your feature request related to a problem? Please describe.
currently, the SaltGUI screen is mostly static. it typically refreshes only on request.

Describe the solution you'd like
Jobs that just finished should leave a notification on the screen.

  • add to top of Jobs side-panel
  • add to top of Jobs page

Additional context
showing just a few latest jobs prevents that screen must be refreshed.
e.g when:

  • a background job was started and the command-box already closed
  • someone else runs an interesting command.

implement by catching events

TODO
there is no "end-job" event, only an "end-job-on-minion"
this makes it hard to detect the end of a job
alternative:

  • collect JIDs from "end-job-on-minion" events
  • wait 3 seconds after the last update from a given JID
  • request the job status
  • when job is finished, report it
  • otherwise just wait longer
@erwindon erwindon self-assigned this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant