Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt Ava default files glob #1913

Open
erights opened this issue Dec 23, 2023 · 1 comment · May be fixed by #2456
Open

adopt Ava default files glob #1913

erights opened this issue Dec 23, 2023 · 1 comment · May be fixed by #2456
Assignees
@turadg
Labels
devex developer experience kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024

Comments

@erights
Copy link
Contributor

erights commented Dec 23, 2023

Repeating Agoric/agoric-sdk#8273

What is the Problem Being Solved?

Our package.json has an "ava": section that configures a custom "files" glob. There are two problems with this:

  1. It requires that every package.json repeat the same custom config. Customizing tool defaults should have a high bar because of the maintenance cost they incur.
  2. The naming scheme chosen puts "test" at the front of what is obviously a test from its path context. To run a particular test from the CLI requires typing "test" three time to pick one: yarn test test/test-something.js. With Ava's default it would be yarn test test/something.test.js and typing the "so" can autocomplete.

Description of the Design

Remove all the custom globs.
Rename test files to .test.js.

Security Considerations

none

Scaling Considerations

none

Test Plan

CI

Upgrade Considerations

none
@erights erights added the bug Something isn't working label Dec 23, 2023
@erights erights mentioned this issue Dec 23, 2023
Closed
@erights
Copy link
Contributor Author

erights commented Dec 23, 2023

This should only be fixed for endo (this issue) in coordination with fixing it for agoric-sdk (Agoric/agoric-sdk#8273)

See Agoric/agoric-sdk#8653 (review)

@erights erights mentioned this issue Dec 23, 2023
Merged
@kriskowal kriskowal added devex developer experience kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 metamask and removed bug Something isn't working metamask labels Jan 6, 2024
@erights erights self-assigned this Mar 4, 2024
@turadg turadg assigned turadg and unassigned erights Sep 9, 2024
@turadg turadg linked a pull request Sep 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
devex developer experience kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

default Ava files glob endojs/endo
3 participants
@turadg @kriskowal @erights