Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean + --dir-dat-name does not follow golden rule #2 #1416

Open
acuteaura opened this issue Jan 26, 2025 · 0 comments
Open

clean + --dir-dat-name does not follow golden rule #2 #1416

acuteaura opened this issue Jan 26, 2025 · 0 comments
Labels
potential-bug A potential issue that needs confirmation and/or triage

Comments

@acuteaura
Copy link

acuteaura commented Jan 26, 2025

Paste the command

npx [email protected] move clean report --dir-dat-name --dat /magpie/media/Games/DAT/*.zip --input /magpie/media/Inbox/gb --output /magpie/media/Games/Emulation/ --input-checksum-min SHA1

Describe the bug

N/A

Expected behavior

Docs state:

  1. If tokens are used with the --output option, only subdirectories that are written to will be considered for cleaning.

For example, if the output directory is specified as --output "games/{mister}", and only Game Boy Color games are found in --input , then only the games/Gameboy/ directory would be considered for cleaning. Other directories that may already exist such as games/GBA/ and games/NES/ would not be considered for cleaning, as Igir did not write there.

In other words, games/{mister} is not equivalent to games/*. Igir will not indiscriminately delete files in games/.

It seems intuitive the same would be true for --dir-dat-name, but it is not.

Kinda blew away 8TiB of ROMs doing this.

Debug logs

N/A

DAT(s) used

No response

igir version

3.0.1

Node.js version

v20.18.1

Operating system

NixOS 24.11 (Vicuna)

Additional context

No response

@acuteaura acuteaura added the potential-bug A potential issue that needs confirmation and/or triage label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-bug A potential issue that needs confirmation and/or triage
Projects
None yet
Development

No branches or pull requests

1 participant