Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on noImplicitOverride #20604

Open
chancancode opened this issue Dec 14, 2023 · 0 comments · May be fixed by #20606 or #20624
Open

Turn on noImplicitOverride #20604

chancancode opened this issue Dec 14, 2023 · 0 comments · May be fixed by #20606 or #20624
Labels
Good for New Contributors TypeScript Work on Ember’s types

Comments

@chancancode
Copy link
Member

Today we discussed and agreed it would be a good idea to turn on the TypeScript noImplicitOverride feature. We often use overrides for integration with glimmer-vm etc, so turning that on for our own code would help catch issues during upgrades.
Manas-maker added a commit to Manas-maker/ember.js that referenced this issue Dec 17, 2023
@Manas-maker
Update compiler-options.json
1ae0dd9 
Fixes emberjs#20604
@Manas-maker Manas-maker linked a pull request Dec 17, 2023 that will close this issue
Open
@shama shama linked a pull request Jan 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good for New Contributors TypeScript Work on Ember’s types
Projects
None yet
Milestone
No milestone
1 participant
@chancancode