Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ember/test-helpers is trying to import from ember-testing but that is not one of its explicit dependencies #1505

Open
simonihmig opened this issue Sep 6, 2024 · 2 comments
Open

@ember/test-helpers is trying to import from ember-testing but that is not one of its explicit dependencies #1505

simonihmig opened this issue Sep 6, 2024 · 2 comments

Comments

@simonihmig
Copy link
Contributor

Although the new version is mostly working without this error, it is coming up reliably when the following conditions are met:

The root issue seems to be in Embroider, posting this here for visibility.
@simonihmig simonihmig mentioned this issue Sep 6, 2024
Open
@andreyfel
Copy link

Seeing that issue in a v2 addon tests when updating from @ember/test-helpers v4.0.2 to v4.0.4 https://github.com/retailnext/ember-bem-helpers/actions/runs/10786506229/job/29913502499

andreyfel added a commit to retailnext/ember-bem-helpers that referenced this issue Sep 11, 2024
@andreyfel
Update transitive dependencies
f976aa7 
pnpm up -r
It will bump `@embroider/core` to the latest and resolve this issue:
emberjs/ember-test-helpers#1505
@andreyfel
Copy link

Confirmed that bumping @embroider/core to the lates fixed the issue.

@lionelB lionelB mentioned this issue Sep 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonihmig @andreyfel