-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this repo really only work with Fastboot now? #46
Comments
Should work fine without fastboot, what issues did you run into? |
We're seeing that ember-page-title simply stops working after upgrading it from 3.2.2 to 4.0.2 (4.0.0 being where ember-cli-head was updated). No errors or anything logged in the console, just no page titles. We added We have a head.hbs file defined with We're also using ember-cli-meta-tags and seeing no issues with it. Is this more likely to be a ember-page-title issue instead of a ember-cli-head issue? I figured it was a ember-cli-head issue since head.hbs is seeing the title, but it's not rendering, and figured it had something to do with that note about fastboot. |
@danconnell could it be this? #16 |
@oskarrough I doubt it. That bug is really old and we weren't having issues with head.hbs until upgrading. And even now, the tags rendered by ember-cli-meta-tags are working but the title tag is not. |
Upon further investigation, this is an issue with ember-page-title. Will log a bug there instead. |
The most likely issue for folks upgrading to 4.x is documented here, but is basically that users have to directly invoke the |
Logged against ember-page-title as ember-cli/ember-page-title#118. My problem was specific to 4.0.2 of that package, where a change was made that is removing the title tag after it's rendered by ember-cli-head. |
The note in the readme:
I don't really understand why Fastboot is a requirement now when there are examples where this repo is useful without Fastboot:
Is the intention of this repo to only support Fastboot apps going forward?
The text was updated successfully, but these errors were encountered: