-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
title does not update after initial load #37
Comments
Hey guys, I'm experiencing the exact same behavior with latest version |
Hmm. I think I may be getting the same thing. Pinging @ronco, since I think this may have to do with ember-cli-head |
Does anyone have a simple example app exhibiting the problem I can look at? |
Thank you for your quick response. At the moment I've only my company's app where I encounter this problem. The interesting part is that my <title>{{model.title}}</title>
{{head-tags headTags=model.headTags}}
|
Thanks @arm1n. I'll see if I can reproduce tonight. |
Do you have a |
@arm1n I think @tim-evans has it. Check out the demo app I put together here. Everything functions correctly to update the page title when there is no #28 illustrates this issue. If you really were not going to use your app with fast boot we could put together a browser only initializer to remove the original |
@ronco @tim-evans Thank you for investigating in this issue, but unfortunately there's no head tag in my |
Do you have a |
@tim-evans Yes, I've also a <title>{{model.title}}</title>
{{head-tags headTags=model.headTags}} The funny thing is that if I add a dummy meta tag like:
The |
Huh. This is super strange. Could you make a simple application with a reproduction for this? That way I can fiddle around with it and try to find the issue. |
Hey Tim, I've tried to setup an ember twiddle, but unfortunately the |
Weird. |
Could you try creating a whole application repo? I'd very much appreciate it ❤️ |
I've just "fixed" a very similar issue in one of my applications. I tracked it down to a JS widget which was also updating the page title using Changing the widget to use May be unrelated to this issue, but the symptoms look the same. |
Was it an internal component or external? |
It was a 3rd party messenger widget, it updated the document.title when it received messages when you had the tab unfocused. |
Ahh, that's tricky. If you have any ideas for how to fix, or solutions, I'd welcome it. |
@tim-evans thankfully in this case I'm working for the company whose messenger widget it was, so I was able to submit a PR! Might be worth a note in the README as a "gotcha" if other people notice similar behaviour to check they aren't using |
🙆 Sounds good!
|
Thanks for this hint, I've also tried to search for any addon manipulating |
Ok so after revisiting this problem in my issue tracker I've tried another round of error cause detection, finally I got it working. Maybe this could be helpful for someone else:
I don't know the ember internals well enough, but at least the change described in 3) made page title updating even after initial page load. So for me the issue has been resolved, ticket could be closed. Thanks for everybody's help! |
@arm1n thanks for the update- that's super weird, but may have to do with pods resolution 🙃 |
Found that the Drift live chat is incompatible with this addon due to Looks like @rlivsey fixed the same problem with Intercom. Have left the following message with support:
Drift customer support response:
I've asked that they do send this change over as a feature request and contact me with any updates. |
I'm using
ember-page-title
in my application, and the title only updates once when first loading the application. It will set the title properly.However, subsequent transitions do not alter the title.
At the moment I do not have a reproduction, but can work on one.
I am using liquid-fire, which I suspect might be related.
The text was updated successfully, but these errors were encountered: