Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run time error when trying the example from billstclair/elm-sortable-table. #160

Open
digitalsatori opened this issue Mar 6, 2019 · 2 comments

Comments

@digitalsatori
Copy link

I encountered runtime error when I test the ‘tripl planner’ example in billstclair/elm-sortable-table.
The “TypeError: Argument 1 (‘node’) to Node.appendChild must be an instance of Node” occurred, when clicking on ‘Rating’ column after clicking on ‘Price’ column. The gif is attached.

Tested in Safari, google chrome and firefox with extension disable, the same error.

sortable-table

@boianr
Copy link

boianr commented Mar 6, 2019

I managed to reproduce this locally. I can't figure why this happens yet, but I narrowed it down to Html.Keyed.node.
Changing line https://github.com/billstclair/elm-sortable-table/blob/b9c4f87eb55b7f96b9f0f5ec717617ea0f08bad6/src/Table.elm#L466 to use Html.node instead of Keyed.node fixes the issue.

This should probably be addressed elsewhere.

@digitalsatori
Copy link
Author

@boianr Thank you for taking time to confirm the issue and narrow it down to the problematic code.
I'm guessing that the issue may not even belong here. Maybe https://github.com/elm/virtual-dom is a more proper place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants