Add test that tests the credentials file

Author: kdp-cloud

mars-cli/mars_lib/authentication.py

@@ -50,7 +50,8 @@ def load_credentials(
     if not all(
         repo in AuthProvider.available_providers() for repo in credentials.keys()
     ):
-        raise ValueError("Credentials dictionary must have keys .")
+        raise ValueError(
+            f"Credentials dictionary must have valid keys. Valid keys are:\n{AuthProvider.available_providers()}")
 
     if not all(
         key in ["username", "password"]

mars-cli/tests/fixtures/bad_credentials_file.json

@@ -0,0 +1,18 @@
+{
+    "webin": {
+        "username": "put-your-username-here",
+        "password": "put-your-password-here"
+    },
+    "metabolights_metadata": {
+        "username": "put-your-username-here",
+        "password": "put-your-password-here"
+    },
+    "metabolights_data": {
+        "username": "put-your-username-here",
+        "password": "put-your-password-here"
+    },
+    "blahblahblah_repo": {
+      "username": "put-your-username",
+      "password": "put-your-password"
+    }
+}

mars-cli/tests/fixtures/max_credentials_file.json

@@ -0,0 +1,14 @@
+{
+    "webin": {
+        "username": "put-your-username-here",
+        "password": "put-your-password-here"
+    },
+    "metabolights_metadata": {
+        "username": "put-your-username-here",
+        "password": "put-your-password-here"
+    },
+    "metabolights_data": {
+        "username": "put-your-username-here",
+        "password": "put-your-password-here"
+    }
+}

mars-cli/tests/fixtures/min_credentials_file.json

@@ -0,0 +1,6 @@
+{
+    "webin": {
+        "username": "put-your-username-here",
+        "password": "put-your-password-here"
+    }
+}

mars-cli/tests/test_authentication.py

@@ -51,3 +51,15 @@ def test_get_metabolights_auth_token():
     # This should be updated to return a more informative error message.
     with pytest.raises(HTTPError):
         get_metabolights_auth_token(fake_credentials_dict["metabolights_metadata"])
+
+
+def test_valid_credentials_file():
+    # Test with a full valid credentials file (all providers)
+    _max_credentials = load_credentials("tests/fixtures/max_credentials_file.json")
+
+    # Test with a partial valid credentials file
+    _min_credentials = load_credentials("tests/fixtures/min_credentials_file.json")
+
+    # Test with a credentials file that has an invalid provider
+    with pytest.raises(ValueError, match="Credentials dictionary must have valid keys."):
+        load_credentials("tests/fixtures/bad_credentials_file.json")