Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning and unpinning a message should ask for confirmation #28399

Open
anoadragon453 opened this issue Nov 6, 2024 · 1 comment
Open

Pinning and unpinning a message should ask for confirmation #28399

anoadragon453 opened this issue Nov 6, 2024 · 1 comment

Comments

@anoadragon453
Copy link
Member

Your use case

What would you like to do?

Pinning a message sends a state event to the room, notifying all room members that a message has been pinned. This action should require a confirmation, such as a modal pop-up to ask the user whether they're sure.

Why would you like to do it?

It's easy to mis-click the "pin" or "unpin" button, as it's right next to "edit" and other actions on the message hotbar:

image

How would you like to achieve it?

A modal pop-up, similar to Discord and other services, seems best.

image

Have you considered any alternatives?

We could make it harder to find the button to pin things, but that seems counter-intuitive.

Additional context

In Discord, if you hold down Shift while clicking on "pin/unpin", it skips the modal pop-up. This is a nice power-user feature.

@Twi1ightSparkle
Copy link

Additionally, if you accidentally unpin something but you didn't notice what, there's not an easy way to undo that and repin the correct message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants