Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element clients hide from the user why a rageshake was rejected #2732

Open
davidegirardi opened this issue Feb 13, 2025 · 1 comment
Open

Comments

@davidegirardi
Copy link

The rageshake server can decide from which apps and under which conditions it should accept a rageshake. It also explains why in the response message.

For example: if a user tries to send their recovery key in their description of the rageshake it will say something like:

This server did not accept the rageshake because it matches a rejection condition: the description matches a recovery key and recovery keys are private. See https://github.com/matrix-org/rageshake/blob/master/docs/blocked_rageshake.md

Similarly, it could say the following for a forked application:

This server did not accept the rageshake because it matches a rejection condition: app or user text rejected. See https://github.com/matrix-org/rageshake/blob/master/docs/blocked_rageshake.md

Element-Web and Element X do not present this information to the user and instead show a generic message:

Failed to send logs: HTTP 400

This does not help the user understand why the bug report was rejected. They could (rightfully so if you ask me) believe that the rageshake feature simply does not work.

@Half-Shot
Copy link
Member

Noting that I spoke to @davidegirardi about trying to make the error response return a JSON object to line up with our other APIs, improving extensibility & potentially allowing for an errcode which would make this error easier to translate in the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants