fix: allow unlabeling draft PRs (#174)

codebytere · web-flow · commit feaf4d4f85fc · 2024-11-01T09:03:44.000-07:00
diff --git a/src/api-review-state.ts b/src/api-review-state.ts
@@ -463,8 +463,8 @@ export function setupAPIReviewStateManagement(probot: Probot) {
       throw new Error('Something went wrong - label does not exist.');
     }
 
-    // Once a PR is merged, allow tampering.
-    if (pr.merged) return;
+    // It's permissible to change labels on merged or draft PRs.
+    if (pr.merged || pr.draft) return;
 
     // Exclude PRs from API review if they:
     // 1) Have backport, backport-skip, or fast-track labels

Original file line number	Diff line number	Diff line change
`@@ -463,8 +463,8 @@ export function setupAPIReviewStateManagement(probot: Probot) {`
`463`	`463`	`throw new Error('Something went wrong - label does not exist.');`
`464`	`464`	`}`
`465`	`465`
`466`		`- // Once a PR is merged, allow tampering.`
`467`		`- if (pr.merged) return;`
	`466`	`+ // It's permissible to change labels on merged or draft PRs.`
	`467`	`+ if (pr.merged \|\| pr.draft) return;`
`468`	`468`
`469`	`469`	`// Exclude PRs from API review if they:`
`470`	`470`	`// 1) Have backport, backport-skip, or fast-track labels`