fix(typescript-client): Replace the while(true) in createFetchWithBackoff with a run closure + setTimeout
#2366
+22
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and explicitly calling it with setTimeout
|
@samwillis thanks for picking this up! Perhaps just push up little app somewhere for testing? I can borrow my wife's iphone (or son's tablet haha) and other's can test as well. |
|
Next step is to reproduce original behavior on IOS & that this PR fixes it. |
I've been able to reproduce the original behavior with Safari on my iPhone. |
kevin-dp
approved these changes
Mar 6, 2025
| } | ||
| } | ||
| } | ||
|
|
||
| return run() |
There was a problem hiding this comment.
Since we don't await anything inside the async function that is returned on L50 (only within the nested run function) we can remove the async keyword on L50.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
while (true)with an explicit call to arunclosure. It should fix the issue seeing in #2364 but will probably need testing on an actual iOS device to try and replicate.iOS Safari tabs goes into a kind of hibernated mode when they are in the background. This throttles
setTimeouts, and appears to cancel thewhile (true)task. By replacing thewhile (true)with an explicit call to arunclosure in asetTimeoutI'm hopeful we just see the next tick of the recursive timeout be throttled, paused and then restarted when the tab come back to the foreground.