Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging the value of a user-specified Authorization header #1757

Open
inqueue opened this issue Aug 7, 2023 · 1 comment
Open

Stop logging the value of a user-specified Authorization header #1757

inqueue opened this issue Aug 7, 2023 · 1 comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. tech debt

Comments

@inqueue
Copy link
Member

inqueue commented Aug 7, 2023

Rally version (get with esrally --version): 2.9.0.dev0 (git revision: a7387ae7ddc53098d640130900a6f5cf2aa5c85e)

Invoked command:

esrally race --track=geonames --pipeline=benchmark-only --client-options='{"default": {"use_ssl": true, "headers":{"Authorization":"ApiKey aE...=="}}}' --target-hosts=target.es.host:9200 --kill-running-processes --test-mode

Description of the problem including expected versus actual behavior:

Rally treats the Authorization header specified in client options like any other header, logging its value in rally.log. Rally should recognize the use of the header and not log its value.

Provide logs (if relevant):

2023-08-07 19:37:59,371 ActorAddr-(T|:46475)/PID:388 esrally.client.factory INFO Creating ES client connected to [{'host': 'target.es.host', 'port': 9200}] with options [{'use_ssl': True, 'headers': {'Authorization': 'ApiKey aE...=='}}]
@jakelandis
Copy link

While you're at it, should probably avoid logging es-secondary-authorization and ES-Client-Authentication as well. Those can also carry credentials but only for specific workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. tech debt
Projects
None yet
Development

No branches or pull requests

3 participants