Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Turn 'fast filter' on by default and ensure tech preview badge shows when turned on #193406

Closed
roshan-elastic opened this issue Sep 19, 2024 · 3 comments · Fixed by #193710
Assignees
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@roshan-elastic
Copy link

Description

Enable the fast filter by default (observability:apmEnableServiceInventoryTableSearchBar), remove call to actions to turn on/off and ensure tech preview icon shows nicely when it's turned on:

Image

Acceptance Criteria

  • observability:apmEnableServiceInventoryTableSearchBar on by default
  • Remove promo messages to enable/disable it
  • Ensure tech preview icon is shown against the fast filter bar (integrate it nicely - this is the most prominent page in APM)
@roshan-elastic roshan-elastic added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Sep 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@roshan-elastic roshan-elastic added enhancement New value added to drive a business result good first issue low hanging fruit labels Sep 19, 2024
@cauemarcondes cauemarcondes self-assigned this Sep 20, 2024
@Siddharthgup
Copy link

Hi, Can you assign this task to me.

@cauemarcondes cauemarcondes removed the good first issue low hanging fruit label Sep 23, 2024
@cauemarcondes
Copy link
Contributor

Hi @Siddharthgup , I've already started working on this. Sorry about that. If you are still interested in contributing you can look at any other issue labelled with "good first issue".

cauemarcondes added a commit that referenced this issue Sep 23, 2024
…shows when turned on (#193710)

closes #193406

<img width="1057" alt="Screenshot 2024-09-23 at 12 37 41"
src="https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b">
<img width="1077" alt="Screenshot 2024-09-23 at 12 37 56"
src="https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451">
<img width="1202" alt="Screenshot 2024-09-23 at 12 38 04"
src="https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 23, 2024
…shows when turned on (elastic#193710)

closes elastic#193406

<img width="1057" alt="Screenshot 2024-09-23 at 12 37 41"
src="https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b">
<img width="1077" alt="Screenshot 2024-09-23 at 12 37 56"
src="https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451">
<img width="1202" alt="Screenshot 2024-09-23 at 12 38 04"
src="https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2">

(cherry picked from commit 886d009)
kibanamachine referenced this issue Sep 23, 2024
…h preview badge shows when turned on (#193710) (#193747)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Turn &#x27;fast filter&#x27; on by default and ensure tech
preview badge shows when turned on
(#193710)](#193710)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T15:54:50Z","message":"[APM]
Turn 'fast filter' on by default and ensure tech preview badge shows
when turned on (#193710)\n\ncloses
https://github.com/elastic/kibana/issues/193406\r\n\r\n<img
width=\"1057\" alt=\"Screenshot 2024-09-23 at 12 37
41\"\r\nsrc=\"https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b\">\r\n<img
width=\"1077\" alt=\"Screenshot 2024-09-23 at 12 37
56\"\r\nsrc=\"https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451\">\r\n<img
width=\"1202\" alt=\"Screenshot 2024-09-23 at 12 38
04\"\r\nsrc=\"https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2\">","sha":"886d009418821ae4b6a22d7630bab0c484f137c2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0"],"title":"[APM]
Turn 'fast filter' on by default and ensure tech preview badge shows
when turned
on","number":193710,"url":"https://github.com/elastic/kibana/pull/193710","mergeCommit":{"message":"[APM]
Turn 'fast filter' on by default and ensure tech preview badge shows
when turned on (#193710)\n\ncloses
https://github.com/elastic/kibana/issues/193406\r\n\r\n<img
width=\"1057\" alt=\"Screenshot 2024-09-23 at 12 37
41\"\r\nsrc=\"https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b\">\r\n<img
width=\"1077\" alt=\"Screenshot 2024-09-23 at 12 37
56\"\r\nsrc=\"https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451\">\r\n<img
width=\"1202\" alt=\"Screenshot 2024-09-23 at 12 38
04\"\r\nsrc=\"https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2\">","sha":"886d009418821ae4b6a22d7630bab0c484f137c2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193710","number":193710,"mergeCommit":{"message":"[APM]
Turn 'fast filter' on by default and ensure tech preview badge shows
when turned on (#193710)\n\ncloses
https://github.com/elastic/kibana/issues/193406\r\n\r\n<img
width=\"1057\" alt=\"Screenshot 2024-09-23 at 12 37
41\"\r\nsrc=\"https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b\">\r\n<img
width=\"1077\" alt=\"Screenshot 2024-09-23 at 12 37
56\"\r\nsrc=\"https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451\">\r\n<img
width=\"1202\" alt=\"Screenshot 2024-09-23 at 12 38
04\"\r\nsrc=\"https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2\">","sha":"886d009418821ae4b6a22d7630bab0c484f137c2"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
4 participants