Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Commit a877a91

Browse files
jmlrtebuildy
andauthored
[7.10] [kibana] add service.httpPortName config in chart (#843) (#958)
Co-authored-by: Julien Mailleret <[email protected]> Co-authored-by: Thomas Decaux <[email protected]>
1 parent 7c69a50 commit a877a91

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

kibana/templates/service.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ spec:
2626
nodePort: {{ .Values.service.nodePort }}
2727
{{- end }}
2828
protocol: TCP
29-
name: http
29+
name: {{ .Values.service.httpPortName | default "http" }}
3030
targetPort: {{ .Values.httpPort }}
3131
selector:
3232
app: {{ .Chart.Name }}

kibana/tests/kibana_test.py

+13
Original file line numberDiff line numberDiff line change
@@ -629,3 +629,16 @@ def test_adding_loadBalancerIP():
629629
r = helm_template(config)
630630

631631
assert r["service"][name]["spec"]["loadBalancerIP"] == "12.5.11.79"
632+
633+
634+
def test_service_port_name():
635+
r = helm_template("")
636+
637+
config = """
638+
service:
639+
httpPortName: istio
640+
"""
641+
642+
r = helm_template(config)
643+
644+
assert r["service"][name]["spec"]["ports"][0]["name"] == "istio"

kibana/values.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ service:
107107
# service.beta.kubernetes.io/cce-load-balancer-internal-vpc: "true"
108108
loadBalancerSourceRanges: []
109109
# 0.0.0.0/0
110+
httpPortName: http
110111

111112
ingress:
112113
enabled: false

0 commit comments

Comments
 (0)