Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang-crossbuild] Can CI skip running when non-code related changes? #457

Open
v1v opened this issue Sep 18, 2024 · 2 comments · Fixed by #469
Open

[golang-crossbuild] Can CI skip running when non-code related changes? #457

v1v opened this issue Sep 18, 2024 · 2 comments · Fixed by #469
Assignees

Comments

@v1v
Copy link
Member

v1v commented Sep 18, 2024

#450 or #452 are changes that are not tested by the CI

@elastic/ingest-eng-prod , can the CI Buildkite pipelines be configured to run smartly what needs to be done?

@rowlandgeoff rowlandgeoff changed the title Can CI skip running when non-code related changes? [golang-crossbuild] Can CI skip running when non-code related changes? Oct 4, 2024
@rowlandgeoff rowlandgeoff self-assigned this Oct 4, 2024
@rowlandgeoff
Copy link
Contributor

I've done a couple test PRs and CI is still running. Will need to keep investigating.

@rowlandgeoff rowlandgeoff reopened this Oct 10, 2024
@rowlandgeoff
Copy link
Contributor

I've compared the settings to the instructions at https://docs.elastic.dev/ci/configuring-pull-requests-for-buildkite and the settings in elastic-agent, where I know I've seen this functionality work. Still not sure what's going wrong.

I've set the golang-crossbuild required status check to any source in the branch protection rules, which I had to do in the elastic-agent repo a little while ago.

One of the test PRs: #475

I will also need to make the json change for the other two pipelines in pull-requests.json, since they run on PRs. But going to wait until I understand why golang-crossbuild is still running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants