Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker warnings in this project #438

Open
v1v opened this issue Aug 15, 2024 · 6 comments
Open

docker warnings in this project #438

v1v opened this issue Aug 15, 2024 · 6 comments
Assignees

Comments

@v1v
Copy link
Member

v1v commented Aug 15, 2024

3 warnings found (use docker --debug to expand):
--
  | - InvalidDefaultArgInFrom: Default value for ARG debian:${DEBIAN_VERSION} results in empty or invalid base image name (line 2)
  | - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 28)
  | - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 29)

and

;t=1723240878886 => WARN: InvalidDefaultArgInFrom: Default value for ARG ${REPOSITORY}/golang-crossbuild:${VERSION}-base${TAG_EXTENSION} results in empty or invalid base  0.0s
bk;t=1723240879036 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 4)                                                                             0.0s
bk;t=1723240879036 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 39)                                                                            0.0s
bk;t=1723240879036 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 71)  
image

https://buildkite.com/elastic/golang-crossbuild/builds/444#01915219-283e-4703-9997-919f05eda82f/6-50
https://buildkite.com/elastic/golang-crossbuild/builds/446#019154e7-1840-4764-bab2-3f12b6165e2a/6-10

@pazone pazone self-assigned this Aug 19, 2024
@v1v
Copy link
Member Author

v1v commented Feb 28, 2025

@pazone , any updates?

@v1v
Copy link
Member Author

v1v commented Mar 14, 2025

@pazone , I've noticed that this issue has been open for quite some time. Could you please provide any updates?

@pazone
Copy link
Contributor

pazone commented Mar 14, 2025

@v1v This is out of the scope. Need to take a look. It's not started. What is the severity?

@v1v
Copy link
Member Author

v1v commented Mar 14, 2025

What is the severity?

I took the lead to use P2 as something to consider, not urgent and important in case those warnings are certainly not warnings once a particular docker version is released.

While P3 is certainly nice to have (not urgent, not important) However If I actually use the wrong assumptions please change the priority, It was not intended to enforce but a way to figure out what's critical, urgent and important while I groomed a few dozens of GH issues

@pazone
Copy link
Contributor

pazone commented Mar 14, 2025

Should we add it to the next sprint?

@v1v
Copy link
Member Author

v1v commented Mar 14, 2025

Should we add it to the next sprint?

I was thinking about it, but I wanna double check our velocity, regardless, I'm in favour of low-hanging-fruit to be sorted when possible, without the burden of going through the planning board, but we can discuss about it together - like planing 70% of our work and leave some room for other things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants