Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmute FrozenSearchableSnapshotsIntegTests#testCreateAndRestorePartialSearchableSnapshot #122831

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Unmute FrozenSearchableSnapshotsIntegTests#testCreateAndRestorePartialSearchableSnapshot #122831

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
036b89b
Unmute `FrozenSearchableSnapshotsIntegTests#testCreateAndRestoreParti…
arteam Feb 18, 2025
f3b9d7a
Add a check for the CLOSED state along with STOPPED
arteam Feb 18, 2025
4298ead
Update x-pack/plugin/searchable-snapshots/src/main/java/org/elasticse…
arteam Feb 18, 2025
0e87a59
Merge branch 'main' into unmute-122693
arteam Feb 18, 2025
cd36e54
Merge branch 'main' into unmute-122693
arteam Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,9 +344,6 @@ tests:
- class: org.elasticsearch.lucene.RollingUpgradeLuceneIndexCompatibilityTestCase
method: testRestoreIndex {p0=[9.1.0, 8.19.0, 8.19.0]}
issue: https://github.com/elastic/elasticsearch/issues/122691
- class: org.elasticsearch.xpack.searchablesnapshots.FrozenSearchableSnapshotsIntegTests
method: testCreateAndRestorePartialSearchableSnapshot
issue: https://github.com/elastic/elasticsearch/issues/122693
- class: org.elasticsearch.lucene.RollingUpgradeLuceneIndexCompatibilityTestCase
method: testClosedIndexUpgrade {p0=[9.1.0, 9.1.0, 8.19.0]}
issue: https://github.com/elastic/elasticsearch/issues/122694
Expand Down
2 changes: 1 addition & 1 deletion ...ts/src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/full/CacheService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ private void ensureLifecycleStarted() {
final Lifecycle.State state = lifecycleState();
assert state != Lifecycle.State.INITIALIZED : state;
if (state != Lifecycle.State.STARTED) {
if (state == Lifecycle.State.STOPPED) {
if (state == Lifecycle.State.STOPPED || state == Lifecycle.State.CLOSED) {
throw new AlreadyClosedException("Failed to read data from cache: cache service is stopped");
} else {
throw new IllegalStateException("Failed to read data from cache: cache service is not started [" + state + "]");
Expand Down