Reduce number of get method variants in ShardGetService
#122175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShardGetService contains multiple get*() methods with different visibility. One `getForUpdate` is only used in a test so it can be moved there. An `innerGet` private method is only called by the private get() method so it can be folded in there to remove one more undocumented `get` variant. A public `get` method is only used in TransportShardMultiGetAction so we can rename it to `mget` to avoid confusion with other `get`. Finally the private `get` is renamed to `doGet` to indicate it's an "inner" private method.
tlrx
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
arteam
approved these changes
Feb 10, 2025
fcofdez
approved these changes
Feb 10, 2025
kingherc
approved these changes
Feb 10, 2025
| @@ -131,7 +130,7 @@ public GetResult get( | |||
| ); | |||
| } | |||
|
|
|||
| private GetResult get( | |||
| private GetResult doGet( | |||
There was a problem hiding this comment.
nit I see the rest of the class uses inner instead of do for private functions, feel free to see if renaming to innerGet might be more conforming.
There was a problem hiding this comment.
I wanted to make a distinction with the other innerGetAndFetch method.
tlrx
added
the
auto-backport
|
Thanks all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShardGetService contains multiple get*() methods
with different visibility.
One
getForUpdateis only used in a test so itcan be moved there.
An
innerGetprivate method is only called bythe private get() method so it can be folded in
there to remove one more undocumented
getvariant.
A public
getmethod is only used inTransportShardMultiGetAction so we can rename
it to
mgetto avoid confusion with otherget.Finally the private
getis renamed todoGetto indicate it's an "inner" private method.