Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't return or accept node_version in the Desired Nodes API #119049

Merged
merged 19 commits into from
Feb 5, 2025

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Dec 19, 2024

Re-submission of #114580

node_version was deprecated in #104209 (8.13) and shouldn't be set or returned in 9.0

Resolve ES-9443

…ic#114580)

> It was deprecated in elastic#104209 (8.13) and shouldn't be set or returned in 9.0

Note: This PR is still pending on the 9.0 transport version
@arteam arteam added >non-issue WIP :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >refactoring labels Dec 19, 2024
@arteam arteam force-pushed the 2-remove-desired-nodes-status branch 2 times, most recently from a1b5f5e to 9c02c10 Compare February 4, 2025 08:01
@arteam arteam force-pushed the 2-remove-desired-nodes-status branch from 9c02c10 to 6c0bc0c Compare February 4, 2025 08:09
@arteam arteam marked this pull request as ready for review February 5, 2025 11:02
@arteam arteam requested a review from DaveCTurner February 5, 2025 11:02
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is vital that this is backported to 9.0 tho.

@arteam arteam added the backport label Feb 5, 2025
@arteam arteam added v9.0.1 auto-backport Automatically create backport pull requests when merged and removed backport labels Feb 5, 2025
@arteam arteam added v9.0.0 and removed v9.0.0 labels Feb 5, 2025
@arteam arteam merged commit 885a551 into elastic:main Feb 5, 2025
18 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119049

arteam added a commit to arteam/elasticsearch that referenced this pull request Feb 5, 2025
…lastic#119049)

Backports elastic#119049 to 9.0

>  Re-submission of elastic#114580
>  node_version was deprecated in elastic#104209 (8.13) and shouldn't be set or returned in 9.0
@arteam arteam deleted the 2-remove-desired-nodes-status branch February 5, 2025 15:03
elasticsearchmachine pushed a commit that referenced this pull request Feb 5, 2025
…119049) (#121775)

Backports #119049 to 9.0

>  Re-submission of #114580
>  node_version was deprecated in #104209 (8.13) and shouldn't be set or returned in 9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue >refactoring v9.0.1 v9.1.0 WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants