Do we want rounded corners on the video player?

[owi92]

I think it looks nicer with rounded corners rather than shap ones 🤷
Though maybe having sharp corners is deliberate and was decided before I came on board.
However if it is only because paella does it like that, it is possible to override.

[oas777]

"No, thanks" was my initial response of course. But then I saw most/all (?) other elements have rounded corners, so that's a "Yes" from me for consistency, if it is.

[owi92]

all (?) other elements have rounded corners

I think that is the case. Just out of curiosity, why was your initial response "no, of course not"?
I went back to look at Lisa's design and there the player does actually have rounded corners, though only slightly (which I think works well, maybe better than the radius I used in my screenshot).
Did you veto that back then? I don't remember discussing it to be honest.

[oas777]

I don't remember either, but the reason for my initial rejection comes from "preserving" the original video which doesn't have round corners.

[LukasKalbertodt]

Interesting, never considered that. You of course have the problem that you cut of a tiny bit of information from the video. But with the small radius that we are talking about, I really can't imagine that being a problem. I would stick to the 4px radius that Lisa suggested though, not using a bigger one. That should already remove the sharpness of the edge. Maybe prepare a PR and we can test out how we all like it?

[dagraf]

I would vote for round corners with a small radius. YouTube has them and I never noticed them being there - untill now.

[owi92]

We decided against this in #1237 (see comments).