Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sections to the Scrobble Album table for Discs #223

Open
chrisjmoss opened this issue Oct 18, 2023 · 2 comments
Open

Add Sections to the Scrobble Album table for Discs #223

chrisjmoss opened this issue Oct 18, 2023 · 2 comments

Comments

@chrisjmoss
Copy link

Describe the solution you'd like
When an album consists of multiple discs, for example box sets, split the Scrobble Album table into sections by disc.

Is your feature request related to a problem? Please describe
If you listen to one CD out of a six CD box set, it can be quite difficult to find and check the relevant tracks. Having the table split into sections by disc would make this easier.

Additional context
MultiDiscSections

@silversonicaxel
Copy link
Contributor

After some investigation, this can be possible only for Discogs researches, since the track field is set as 1-1, 1-2, 1-3 ... 2-1, 2-2 for songs of different discs.

While in Lastfm this separation is not shown, they are all listed with an index starting from 1 til the end no matter how many discs.

Question is, do we want a different implementation for Discogs and LastFm researches, so research form same album can show different views in the app?


If so, it's just a matter of analyzing the track field, if it is a [digit]-[digit] we know there are discs.

@elamperti
Copy link
Owner

Each service has their own way of sorting and storing their tracklists for an album, so on our side we should handle this individually in each transformer (see tracksResponse.transformer.ts in lastfm/discogs clients) so they have a new property section. If lastfm in particular doesn't provide sections (IIRC it doesn't), this would end up being an undefined prop, and that's fine. The component(s) listing the tracks should then use the section info to show subtitles (i.e. the sections) accordingly. I think that should be feasible by modifying <ScrobbleList>.

If an album has no sections (or just one) then there shouldn't be a section title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants