Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default BOOTSTRAP_BINDER_NAME configurable #14

Open
galves opened this issue Feb 22, 2017 · 1 comment
Open

Make the default BOOTSTRAP_BINDER_NAME configurable #14

galves opened this issue Feb 22, 2017 · 1 comment

Comments

@galves
Copy link

galves commented Feb 22, 2017

It is a bit of a pain having to explicitly define the binder name for each verticle in the json deployment config, when I imagine most users have the same binder for each verticle deployment?

Also it creates a confusing error when the binder is not set:

"Guice bootstrap binder class com.englishtown.vertx.guice.BootstrapBinder was not found. Are you missing injection bindings?"

This should at most result in a warning because you may intentionally be using just a parent injector.

Please can we add a setter for it the binder in the verticle factory then pass it to the loader.

Thanks

@dano
Copy link
Contributor

dano commented Dec 5, 2017

FWIW, the issue with the confusing error is fixed by #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants