Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a link to EditorConfig-Action #117

Open
xuhdev opened this issue Jul 3, 2019 · 6 comments
Open

Include a link to EditorConfig-Action #117

xuhdev opened this issue Jul 3, 2019 · 6 comments
Assignees

Comments

@xuhdev
Copy link
Member

xuhdev commented Jul 3, 2019

I would add on the website a link to EditorConfig-Action (excellent work!), which uses eclint. @jedmao opinions?

@xuhdev xuhdev self-assigned this Jul 3, 2019
@xuhdev
Copy link
Member Author

xuhdev commented Jul 3, 2019

cc @zbeekman

@jednano
Copy link
Member

jednano commented Jul 3, 2019

I don't see why not; though, ECLint is one of those projects that seemed like a good idea at the time, but now I regret creating it. Only because it's not AST-aware, which means it can't really do a reliable job at fixing or even checking indentation.

I recommend Prettier, which supports multiple file formats as well as EditorConfig. On top of that, language specific tools should be doing the job.

@zbeekman
Copy link

zbeekman commented Jul 9, 2019

While I agree that tools which are AST aware can provide much better functionality, for some languages, like Fortran (modern and antiquated) there are currently no such tools and eclint & others play a valuable role. If Prettier supported Fortran I would probably use that instead, however, for a lot of languages that just isn't an option.

I would fully support a link to EditorConfig-Action on the EditorConfig website, if you would like to put one there.

@xuhdev
Copy link
Member Author

xuhdev commented Jul 10, 2019

@zbeekman Do you have a logo? If you don't have one, I'm thinking about what can be the best image as a placeholder...

@zbeekman
Copy link

zbeekman commented Jul 10, 2019

https://github.com/zbeekman/EditorConfig-Action/blob/master/assets/GH-social.xcf is the GIMP file I used for the social preview. Feel free to hack out the topline github logo & text or otherwise modify it. Otherwise, the combination of OctoCat Double Blink, Square Heart and EditorConfig Logo is the closest thing I have to an official logo. These could stand to have an anti-aliasing pass, but I have other things I need to do at the moment.

Something like:

ocdb sqhr ecl

@xuhdev
Copy link
Member Author

xuhdev commented Aug 5, 2019

@zbeekman Sorry for the delay. Would you mind sending a PR for this? I'm not sure though whether GitHub allows us to do so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants