Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit be25212

Browse files
committedJan 12, 2023
Fix rebase screw-up
Signed-off-by: Thomas Mäder <[email protected]>
1 parent 68b95a3 commit be25212

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
 

‎packages/terminal/src/browser/terminal-widget-impl.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import { Terminal, RendererType } from 'xterm';
1818
import { FitAddon } from 'xterm-addon-fit';
1919
import { inject, injectable, named, postConstruct } from '@theia/core/shared/inversify';
20-
import { ContributionProvider, Disposable, Event, Emitter, ILogger, DisposableCollection, Channel } from '@theia/core';
20+
import { ContributionProvider, Disposable, Event, Emitter, ILogger, DisposableCollection, Channel, OS } from '@theia/core';
2121
import { Widget, Message, WebSocketConnectionProvider, StatefulWidget, isFirefox, MessageLoop, KeyCode, codicon, ExtractableWidget } from '@theia/core/lib/browser';
2222
import { isOSX } from '@theia/core/lib/common';
2323
import { WorkspaceService } from '@theia/workspace/lib/browser';
@@ -487,8 +487,8 @@ export class TerminalWidgetImpl extends TerminalWidget implements StatefulWidget
487487
const { cols, rows } = this.term;
488488

489489
const terminalId = await this.shellTerminalServer.create({
490-
shell: this.options.shellPath || this.shellPreferences.shell,
491-
args: this.options.shellArgs || this.shellPreferences.shellArgs,
490+
shell: this.options.shellPath || this.shellPreferences.shell[OS.type()],
491+
args: this.options.shellArgs || this.shellPreferences.shellArgs[OS.type()],
492492
env: this.options.env,
493493
strictEnv: this.options.strictEnv,
494494
isPseudo: this.options.isPseudoTerminal,

0 commit comments

Comments
 (0)
Please sign in to comment.