Skip to content

Commit daa1836

Browse files
dev: Update pnpm to latest v10.4.1 and fix Netlify build (#2422)
- Update to lockfile version 9 without updating dependencies (Used by pnpm 9+ and 10+) - Add npm corepack configuration for pnpm to latest version 10.4.1. This is also respected by Netlify fixing the build issues. - Set engine version restriction for pnpm to ^10.4.1. - Update dev container - Update README - ci: Use pnpm version from corepack's package.json property packageManager. This is supported by pnpm-setup action. - ci: Update pnpm-setup action and pin version
1 parent 64fba38 commit daa1836

File tree

6 files changed

+18068
-25020
lines changed

6 files changed

+18068
-25020
lines changed

.devcontainer/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ ENV CHROME_BIN=/usr/bin/chromium
1515
# RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
1616

1717
# Install and configure pnpm
18-
RUN su node -c "npm install -g pnpm@8"
18+
RUN su node -c "npm install -g pnpm@10"
1919
RUN su node -c "pnpm config set store-dir /home/node/.pnpm-store"

.github/workflows/ci.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,10 @@ jobs:
2828
with:
2929
node-version: 18
3030

31-
- uses: pnpm/action-setup@v4.0.0
31+
- uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
3232
name: Install pnpm
3333
id: pnpm-install
3434
with:
35-
version: 8
3635
run_install: false
3736

3837
- name: Build

.github/workflows/publish.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,10 @@ jobs:
4242
node-version: "18"
4343
registry-url: "https://registry.npmjs.org"
4444

45-
- uses: pnpm/action-setup@v4.0.0
45+
- uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
4646
name: Install pnpm
4747
id: pnpm-install
4848
with:
49-
version: 8
5049
run_install: false
5150

5251
- name: "Install Packages"

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Independently of the assigned milestone, contributions are always accepted and a
4444
### First time setup
4545

4646
- Install [node.js](https://nodejs.org/) (only Node v18.19+ < 19 is currently supported)
47-
- Install pnpm: <https://pnpm.io/installation> (use pnpm 8.6.2+)
47+
- Install pnpm: <https://pnpm.io/installation> (use pnpm 10.4.1+) or use [corepack](https://nodejs.org/docs/latest-v18.x/api/corepack.html) to enable the recommended version
4848
- Clone this repository
4949
- Install dependencies: `pnpm i --frozen-lockfile`
5050

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
"name": "jsonforms-monorepo",
33
"engines": {
44
"node": "^18.19.0",
5-
"pnpm": ">=7.13.4"
5+
"pnpm": "^10.4.1"
66
},
7+
"packageManager": "[email protected]+sha256.4b702887986995933d4300836b04d6d02a43bc72b52e4f7e93a4ca608b959197",
78
"scripts": {
89
"lerna": "lerna",
910
"preparePublish": "git clean -dfx && pnpm i --frozen-lockfile && pnpm run clean && pnpm run build && pnpm run doc && pnpm run test",

0 commit comments

Comments
 (0)