Skip to content

Commit 7f0f672

Browse files
committed
dev: Update Node version to 18.19+
- Adapt README - Update node versions for CI, Netlify, dev container - Update @types/node dependencies to ^18.19.4
1 parent c2836a5 commit 7f0f672

File tree

12 files changed

+27
-31
lines changed

12 files changed

+27
-31
lines changed

.devcontainer/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.191.1/containers/javascript-node/.devcontainer/base.Dockerfile
22

3-
# [Choice] Node.js version: 16
4-
ARG VARIANT="16"
3+
# [Choice] Node.js version: 18
4+
ARG VARIANT="18"
55
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:1-${VARIANT}
66

77
# Install chromium and point the CHROME_BIN environment variable to it

.devcontainer/devcontainer.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
"name": "Node.js",
55
"build": {
66
"dockerfile": "Dockerfile",
7-
// Update 'VARIANT' to pick a Node version: 16
7+
// Update 'VARIANT' to pick a Node version: 18
88
"args": {
9-
"VARIANT": "16"
9+
"VARIANT": "18"
1010
}
1111
},
1212
// Set *default* container specific settings.json values on container create.

.github/workflows/ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- name: Setup node
2121
uses: actions/setup-node@v3
2222
with:
23-
node-version: 16
23+
node-version: 18
2424

2525
- uses: pnpm/[email protected]
2626
name: Install pnpm

.github/workflows/publish.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
- name: "Setup node"
3939
uses: "actions/setup-node@v3"
4040
with:
41-
node-version: "16"
41+
node-version: "18"
4242
registry-url: "https://registry.npmjs.org"
4343

4444
- uses: "pnpm/[email protected]"

.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v16.20.1
1+
v18.19.0

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ See our [migration guide](https://github.com/eclipsesource/jsonforms/blob/master
3030

3131
### First time setup
3232

33-
- Install [node.js](https://nodejs.org/) (only Node v16.13+ < 17 is currently supported)
33+
- Install [node.js](https://nodejs.org/) (only Node v18.19+ < 19 is currently supported)
3434
- Install pnpm: <https://pnpm.io/installation> (use pnpm 8.6.2+)
3535
- Clone this repository
3636
- Install dependencies: `pnpm i --frozen-lockfile`

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "jsonforms-monorepo",
33
"engines": {
4-
"node": "^16.14",
4+
"node": "^18.19.0",
55
"pnpm": ">=7.13.4"
66
},
77
"scripts": {

packages/angular-material/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
"@rollup/plugin-replace": "^5.0.1",
108108
"@types/jasmine": "~3.8.0",
109109
"@types/lodash": "4.14.149",
110-
"@types/node": "^18.10.0",
110+
"@types/node": "^18.19.4",
111111
"@typescript-eslint/eslint-plugin": "^5.54.1",
112112
"@typescript-eslint/parser": "^5.54.1",
113113
"babel-loader": "^8.0.6",

packages/examples/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
},
5252
"devDependencies": {
5353
"@jsonforms/core": "workspace:*",
54-
"@types/node": "^16.18.34",
54+
"@types/node": "^18.19.4",
5555
"@typescript-eslint/eslint-plugin": "^5.54.1",
5656
"@typescript-eslint/parser": "^5.54.1",
5757
"eslint": "^7.32.0",

packages/vue-vanilla/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"@types/chai": "^4.2.11",
6161
"@types/jest": "^27.4.1",
6262
"@types/mocha": "^5.2.4",
63-
"@types/node": "^16.18.34",
63+
"@types/node": "^18.19.4",
6464
"@typescript-eslint/eslint-plugin": "^5.54.1",
6565
"@typescript-eslint/parser": "^5.54.1",
6666
"@vue/cli-plugin-babel": "~4.5.19",

packages/vue/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"@jsonforms/core": "workspace:*",
5454
"@rollup/plugin-alias": "^3.1.8",
5555
"@types/jest": "^27.4.1",
56-
"@types/node": "^16.18.34",
56+
"@types/node": "^18.19.4",
5757
"@typescript-eslint/eslint-plugin": "^5.54.1",
5858
"@typescript-eslint/parser": "^5.54.1",
5959
"@vue/cli-plugin-babel": "~4.5.19",

pnpm-lock.yaml

+14-18
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)