Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dsl to work with 2020-12 ? #137

Open
tfrancart opened this issue Jun 13, 2024 · 4 comments
Open

Update dsl to work with 2020-12 ? #137

tfrancart opened this issue Jun 13, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tfrancart
Copy link

Describe the feature

Any plan to support 2020-12 version in the dsl package ? Thanks !

@tfrancart tfrancart added the enhancement New feature or request label Jun 13, 2024
@CheesyBoy123
Copy link
Contributor

Hey @tfrancart can you help me understand what you mean by plans to support 2020-12? It should be already supported.
https://github.com/eclipse-vertx/vertx-json-schema/blob/master/src/main/java/io/vertx/json/schema/Draft.java#L51

@CheesyBoy123
Copy link
Contributor

CheesyBoy123 commented Aug 15, 2024

Hey @tfrancart I misunderstood your question! I talked with PK about this to better understand. If this something you would like to contribute to? If not a list of the missing features would be a good place for me to start 😀

@tfrancart
Copy link
Author

Hello thanks for your feedback !
We started with our own adaptation of another lib (https://github.com/everit-org/json-schema/tree/master/core/src/main/java/org/everit/json/schema) to create JSON schema programmatically. Our adaptation is here : https://github.com/sparna-git/shacl-play/tree/master/shacl-doc/src/main/java/fr/sparna/jsonschema/model
Our use-case is to create JSON schema automatically from SHACL Shapes (RDF shapes language)
We cannot contribute to the code but we would be very happy to try it by adapting our code to use your lib and give you feedback, instead of our own implementation that we have no interest to maintain.

@CheesyBoy123
Copy link
Contributor

Thanks for the info @tfrancart I'll have a look in a few days. I am currently away on vacation!

@CheesyBoy123 CheesyBoy123 added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants