-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set environment variables for scripts #802
Set environment variables for scripts #802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 59.48% 59.64% +0.16%
==========================================
Files 36 36
Lines 5800 5880 +80
==========================================
+ Hits 3450 3507 +57
- Misses 2350 2373 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6e5ebfd
to
38ed1d3
Compare
Turns out, setenv can block if you feed it NULL. So I made a safe setenv function to prevent that. Also added some documentation. |
dddb51e
to
ac6f1fd
Compare
I added the icon path function to this pr as well. Tests fail, because the old behaviour of the pixbuf creation was to continue searching the icon path when an invalid icon was found. This behaviour changed to returning the path to the invalid icon, thus not being able to create the pixbuf. |
ac6f1fd
to
beaba34
Compare
CI appears to be failing now. |
See #802 (comment) |
Whoops, that should teach me to review code at 1 am 🙈 That's fine, I don't expect that there will be many invalid icons and, but please fix the tests :) |
24b3e8d
to
0486ca5
Compare
I also fixed a test that was broken because of different behaviour. Now the first icon path is returned instead of the first valid icon path.
0486ca5
to
bc3de38
Compare
I forgive you :). The tests should now be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses #767 and #653. This PR sets environment variables for scripts to use. Let me know if I have to add more or if the naming should be changed. I still need to do the documentation, but I wanted to get some comments before that.