Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret - as STDIN config file #466

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

bebehei
Copy link
Member

@bebehei bebehei commented Dec 23, 2017

As proposed in #357

@tsipinakis
Copy link
Member

tsipinakis commented Dec 23, 2017

While kinda a hack, isn't this already possible by giving /dev/stdin as the config file?

Edit: Actually, this isn't even a hack now that I think about it, it's intended behaviour and exactly what this PR does internally.

@bebehei
Copy link
Member Author

bebehei commented Dec 23, 2017

... so what's your resolution?

@tsipinakis
Copy link
Member

... so what's your resolution?

I'd say this is unnecessary since there's already a working solution that resolves this usecase so I'd close this but it's up to debate.

@bebehei
Copy link
Member Author

bebehei commented Dec 23, 2017

The only reason, why I want to add this, is because common unix tools interpret a single dash also as STDIN (e.g.: grep, cat, etc...). When I have to give stdin as a parameter I always want to check first, if the program is able to interpret -. I actually never fall back to /dev/stdin.

Copy link
Member

@tsipinakis tsipinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't hurt to support it I guess Famous last words

@tsipinakis tsipinakis merged commit db0796b into dunst-project:master Jan 5, 2018
@bebehei bebehei deleted the stdinconfig branch January 6, 2018 00:48
karlicoss pushed a commit to karlicoss/dunst that referenced this pull request Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants