-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeout beyond ~10 minutes does not work #657
Comments
We had a similar bug 2 weeks ago. Does the current master work? (PR #647 fixed it). What does |
with both 1.4.1 and master. But I'll test with master to see whether it is already fixed. |
Could you post the dunstrc you're using? Mind the idle_threshold value, if that's enabled and dunst detects you're idle the timeout timer will restart. |
Oh, that might be the reason. I have copied the default configuration and the idle_timeout was set to 120. Will test again. |
Got it down to the milisecond: -t 709821 works, -t 709822 does not. |
I can't reproduce this locally from the tests I ran (another one is running right now - with the cycle time of this it's hard to pinpoint). So, let's get to debugging:
OT: @bebehei What would you say of merging that branch to master and adding more such calls, we could use a much more verbose |
I have been able to capture output when the bug was triggered. |
Oh, and it is somehow still triggered by idling. If I am reasonably active during the timeout, it does not trigger. |
Were these notifications shown the entire time? Logs show the The timer doesn't tick while the notifications are hidden. You killed dunst at
Meaning they had ~5 more minutes till they time out. |
okay, that must be the reason then. I guess you can close this issue, I will report back if I end up triggering it again at some point. |
I think those calls cover mainly the stuff, what a debugger should be used for. Using such verbose "comments" blow up the code, amount of logs used and cover only a small use case. I'm not that convinced to be a good idea. |
True, this will mostly be useful to address the case of remote debugging where neither of us can reproduce the issue, such as this or #620. And as you mentioned can be useful as "comments" as well. If you're worried about performance we could compile these out in release builds. |
I'm trying to have a notification time out at n minutes by calling
notify-send -t $(( 60000*$n )) "some message"
. This works correctly for n <= 10, but fails for n >= 15 (I could pinpoint it further if neccessary) in the sense that the notification just keeps showing after the supposed timeout.I have checked with dbus-monitor, and the transmitted information seems correct in all cases, so I suspect that this is a bug in dunst and not somewhere else.
Installation info
v1.4.1
package
ormanual
linux mint 19.2
, kernel5.0.0
The text was updated successfully, but these errors were encountered: