Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass variables as params #653

Closed
bebehei opened this issue Aug 14, 2019 · 3 comments
Closed

Pass variables as params #653

bebehei opened this issue Aug 14, 2019 · 3 comments
Labels

Comments

@bebehei
Copy link
Member

bebehei commented Aug 14, 2019

I think we should pass the flags in the notification script as environment variables.

dunst/src/notification.c

Lines 123 to 130 in 53e7f3d

int ret = execlp(n->script,
n->script,
appname,
summary,
body,
icon,
urgency,
(char *)NULL);

Enhancing this, is a PITA and doesn't scale. We also would allow passing flags (#639) and adding new fields would be easy to document and remove later.

It may be also a fix for #645, as you could easily add the desktop_entry field as an environment variable and you could filter it in the script properly.

@tsipinakis
Copy link
Member

Why the help wanted tag?

@bebehei
Copy link
Member Author

bebehei commented Aug 14, 2019

idk.

@fwsmit
Copy link
Member

fwsmit commented Jun 7, 2021

Implemented by #802

@fwsmit fwsmit closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants