-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dunst crashes periodically #630
Comments
Hi, Can't really say why it happened from the error posted. As you said the dbus-monitor log when it happens would be great and additionally if you can, it would also be useful to get a backtrace from the crash. |
Hi Nikos, Attaching obtained logs:
|
Please let me know if I can assist in any other way |
Unfortunately that log didn't give me anything. However, looking at the code it seems like the only place that can produce a BadValue error is the window positioning logic. Can you build tsipinakis@232b550 with Also, is this something you can reliably reproduce or does it happen sporadically? |
I get the same error, but it happens each time i use pywal for some reason |
@DragonGhost7 Can you try also try to get the debug print as I mentioned in the previous comment? |
Hello @tsipinakis , here are my debug log and and dbus-monitor output. I'm still not sure how to bisect it but I will be figuring out how to do it now. |
Unfortunately that log doesn't say much. What I meant was compiling from tsipinakis@232b550 that adds some extra output in order to get information relevant to this. In a nutshell:
And post the output when the crash happens, it should hopefully provide enough information to track this down. Additionally doing a bisect would be amazing, you can use a comment I left in a previous issue as a guide on how to do that. |
Hello @tsipinakis , your comment was rather helpfull. |
Excuse the inactivity on this, real life caught up with me. @DragonGhost7 Since you can reproduce this reliably as you said can you try to get a minimal pywal config that causes this so that I can reproduce this on my side as well? |
Hello, while this time i realizes that the problem is in fact caused by xrdb. |
I figured as much given that the commit the bisect pointed at is supposed to respond to xrdb calls. Could you be specific with what xrdb command you are running? Additionally: What's the output of |
I use
|
The xprop output looks about what I'd expect. But at least we got a cause. I still can't reproduce this, xrdb works properly :/. Can you clone |
I did, and here`s output
|
There it is, somewhere along the drawing chain we're getting a 0 on the window height. I'll sign off for today, I'll add some more debug output to try to narrow this down further tomorrow. Until then, have you tried using the default dunstrc rather than your own to see if it still happens? |
Yes i just did, and there is no issue. |
Oh, that's a bit hint can you post your dunstrc? |
Here it is.
|
Reproduced, I'll look more into this tomorrow. |
Thanks a lot ! |
Draw should not be called when there are no notifications in the queue. This for unknown reasons causes a crash the next time we attempt to get the currently active window with a BadValue error from XGetWindowProperty. Fixes dunst-project#630.
Weirdly the crash isn't inside @DragonGhost7 Can you build tsipinakis@69a682c, confirm this fixes the issue? |
Build functional, issue has disappeared. |
I run dunst on manjaro, installed it from community packages.
Last few weeks I observe periodical crashes, as I guess, caused by Slack notifications.
Error is as following:
Warning about flameshot is unrelated to crash, it occured some time before it crashed.
Will append dbus-monitor log later, when the error occurs again.
The text was updated successfully, but these errors were encountered: