Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken wrapping in 1.4.0 #620

Open
xbruno opened this issue Apr 3, 2019 · 17 comments
Open

Broken wrapping in 1.4.0 #620

xbruno opened this issue Apr 3, 2019 · 17 comments

Comments

@xbruno
Copy link

xbruno commented Apr 3, 2019

Hello,
since the update to dunst 1.4.0-1, the dynamic width does not work.
Here with this example : notify-send 'hello' 'hello world - hello world'

My dunstrc : https://pastebin.com/raw/ERgs9Z5c

  • Version: 1.4.0-1
  • Install type: pacman.
  • Archlinux up to date.

Thanks

@tsipinakis
Copy link
Member

This works on my end what do you see broken?

The screenshot you posted doesn't appear to load.

@xbruno
Copy link
Author

xbruno commented Apr 3, 2019

The screenshot is on toile-libre.org and for the moment is '503 Service Unavailable'.

@tsipinakis
Copy link
Member

Took a while to get to this but I wanted to find time to actually set up an Arch environment to try to reproduce this myself but I was entirely unsuccessful. Your dunstrc works fine both in Debian and in Arch for me.

Does reverting to 1.3 fix this?

Can you run a git bisect to determine the commit that caused this? Feel free to ask if you need help with this.

@xbruno
Copy link
Author

xbruno commented Apr 15, 2019

I reverted to 1.3.2-2 and dunst works fine.

I look for run a git bisect.

@xbruno
Copy link
Author

xbruno commented Apr 16, 2019

I have installed git and try.
can you tell me what to do?

@tsipinakis
Copy link
Member

First clone & make sure you can compile dunst, run:

git clone https://github.com/dunst-project/dunst
cd dunst
make
./dunst

Make sure that this starts dunst up and it works, then do the following to find what broke it:

First start the bisect with:

make clean
git bisect start
git bisect bad HEAD
git bisect good v1.3.2

Then to do the actual bisect do

make
./dunst

Here send a notification from another terminal to see if the issue exists and run git bisect bad if it's broken or git bisect good if it's not.

Repeat the last 3 commands until it prints out the commit that broke it. It'll look something like

commit XYZ
Author: blah
...

@xbruno
Copy link
Author

xbruno commented Apr 16, 2019

thank you for explanation.
Result:
4f510e1 is the first bad commit
commit 4f510e1
Author: Benedikt Heine [email protected]
Date: Mon Feb 25 19:01:34 2019 +0100

@hg8
Copy link

hg8 commented Apr 22, 2019

For those who need it you can downgrade to 1.3.2.2 on Arch Linux using :

$ sudo pacman -U https://archive.archlinux.org/packages/d/dunst/dunst-1.3.2-2-x86_64.pkg.tar.xz

I have the same issue, but could not solve it by downgrading. The issue seemed to be linked to the font used.

font = Iosevka 8
2019-04-22-085832_505x131_scrot

font = Hack 8
2019-04-22-090142_541x118_scrot

using

$ dunst --version
Dunst - A customizable and lightweight notification-daemon 1.4.0 (2019-03-30)

Hope this can gives pointers.

@tsipinakis
Copy link
Member

The biggest change in the commit @xbruno pointed at is that we no longer assume DPI is 96 and calculate it from the screen dimensions by default.

@xbruno Can you try running:

echo "Xft.dpi: 96" | xrdb - merge

and restart dunst, does that fix it?

If so, I believe the issue is in older versions of dunst as well but the dpi change simply revealed it.

@tsipinakis
Copy link
Member

tsipinakis commented Apr 22, 2019

The issue seemed to be linked to the font used.

I just tried installing Iosevka on Arch but still cannot reproduce this with the given notification.

@hg8 Can you upload your full dunstrc as well?

Also can you build tsipinakis@9935eb2, run dunst with -verbosity debug and upload the output? This is to find out the DPI as I suspect this has something to do with it.

@hg8
Copy link

hg8 commented Apr 22, 2019

Here is my dunstrc.

The biggest change in the commit @xbruno pointed at is that we no longer assume DPI is 96 and calculate it from the screen dimensions by default.

I have Xft.dpi: 220 in my .Xresources file. Setting my dpi to 96 don't have effects either.

Also can you build tsipinakis/dunst@9935eb2, run dunst with -verbosity debug and upload the output?

$ ./dunst -verbosity debug
DEBUG: RUN
DEBUG: Using DPI: 220.271003

The output is the same with whatever font I use.

@xbruno
Copy link
Author

xbruno commented Apr 22, 2019

I run :
echo "Xft.dpi: 96" | xrdb -merge
restart dunst and now dunst 1.4.0-1 works fine.

@tsipinakis
Copy link
Member

Weird. @hg8 can you also run a bisect and see what that gives?

@hg8
Copy link

hg8 commented Apr 23, 2019

@tsipinakis Maybe I should open a different issue ? I now think my problem is different, and I could not get to reproduce it with any other than font Iosevka. It's strange.

Weird. @hg8 can you also run a bisect and see what that gives?

That's not needed, even at 1.2.0 I can reproduce the issue.

@tsipinakis
Copy link
Member

@hg8 Did this start happening recently or did you just discover it now?
There's also #624. As I've said there I have a feeling this is something to do with pango, our font rendering library.

It just seems weird that 4-5 people have similar but not quite the same issue at the same time - seemingly not tied to dunsts version.

@hg8
Copy link

hg8 commented Apr 24, 2019

@tsipinakis

Did this start happening recently or did you just discover it now?

I just started to use Dunst 2 days ago so I can't tell if it was working before.


Well now I have to say I am completely at loss...
After a reboot the issue is back on Hack font :
2019-04-24-044052_487x99_scrot

So I tried to switch to Iosevka font and ....
2019-04-24-044402_434x100_scrot

Reboot, Iosevka still working, Hack not working...
Downgrade to dunst-1.3.2.2, Iosevka still working, Hack not working...

I really don't understand what's going and I have no idea how to help you debug this...

But maybe you are right then, the issue may come from pango and not dunst itself?

@tsipinakis tsipinakis changed the title dynamic width does not work since dunst 1.4.0-1 Broken wrapping in 1.4.0 May 2, 2019
@fwsmit
Copy link
Member

fwsmit commented Feb 18, 2022

Hi, is this still an issue with the current dunst version?

@bynect bynect added the stale label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants